Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 backported "attempt to type the return value of actions created by createThunkAction" #42396

Merged

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented May 8, 2024

Manual backport of #42328

@metabase-bot metabase-bot bot added the was-backported apply this to PRs that are themselves backports label May 8, 2024
…ion (#42328)

* attempt to type the return value of actions created by createThunkAction

* use built in Awaited instead of custom AwaitedIfPromise
@npretto npretto force-pushed the backport-1a7879031de513a52f5d504a15673785494cd8fe branch from eff36f5 to bb78c9f Compare May 9, 2024 08:55
Copy link

replay-io bot commented May 9, 2024

Status Complete ↗︎
Commit bb78c9f
Results
⚠️ 2 Flaky
2370 Passed

@npretto npretto requested a review from a team May 9, 2024 10:29
Copy link
Contributor

@heypoom heypoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backported changes matched what I remembered from reviewing this PR, so this should be fine. We can merge once tests pass.

@npretto npretto merged commit 77a6389 into release-x.49.x May 9, 2024
107 checks passed
@npretto npretto deleted the backport-1a7879031de513a52f5d504a15673785494cd8fe branch May 9, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was-backported apply this to PRs that are themselves backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants