Tweak the Model explanation banner #42413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
Closed
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 8, 2024
rafpaf
force-pushed
the
browse/banner-tweak
branch
from
c76bae7
to
f82e6a9
Compare
|
rafpaf
force-pushed
the
browse/nav
branch
2 times, most recently
from
d33df74
to
0fcdcf0
Compare
rafpaf
force-pushed
the
browse/banner-tweak
branch
from
f82e6a9
to
7c9c686
Compare
iethree
approved these changes
May 8, 2024
rafpaf
force-pushed
the
browse/banner-tweak
branch
from
7c9c686
to
0ce90ee
Compare
rafpaf
force-pushed
the
browse/banner-tweak
branch
from
0ce90ee
to
7018673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the banner that appears on the Browse models page (the
ModelExplanationBannercomponent) by replacing the existing code for dismissing the banner with theuseUserSettinghook.The previous implementation involved directly dispatching a Redux action. This has been replaced by the
useUserSettinghook which simplifies the logic and makes the code cleaner.Test the dismissal of the
ModelExplanationBannercomponent by going to the Browse models page and dismissing the banner. It should not show up again on subsequent visits.