convert SocketChannelEndpoint to SocketChannel
#42419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paoliniluis
added
the
backport
dpsutton
reviewed
May 8, 2024
|
escherize
commented
May 8, 2024
Comment on lines
+154
to
+160
| (defn log-unexpected-transport! | ||
| "Log an error when an unexpected transport is encountered." | ||
| [transport] | ||
| (let [transport-type (type transport)] | ||
| (when-not (contains? @*reported-types transport-type) | ||
| (log/errorf "Unexpected transport type encountered in `canceled?`: %s" transport-type)) | ||
| (swap! *reported-types conj transport-type))) |
There was a problem hiding this comment.
We just want to log this error once per unexpected type
johnswanson
approved these changes
May 8, 2024
escherize
deleted the
bcm-convert-socket-channel-endpoints-to-socket-channels
branch
|
@escherize Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
* convert `SocketChannelEndpoint` to `SocketChannel` * Remove fatal logging (used for debugging) * check for nil channel + log on unknown type * only log unexpected transport types once
metabase-bot bot
added a commit
that referenced
this pull request
May 8, 2024
* convert `SocketChannelEndpoint` to `SocketChannel` * Remove fatal logging (used for debugging) * check for nil channel + log on unknown type * only log unexpected transport types once Co-authored-by: bryan <bryan.maass@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13771
During SSL, the getTransport method was returning a type that we didn't expect:
SocketChannelEndpoint, and that type was unable to be cast into aSocketChannel. Calling.getChannelon theSocketChannelEndpointreturns aSocketChannel, so that is what we do.