Merge master #42426
Merged
Merge master #42426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use palette for rendering * add unit tests for chart label colors * cleanup test code * update unit test name * cleanup color handler * use theme.fn.themeColor to get color
* Items as links * unit tests
* Add trackColumnExtractViaHeader helper * Add Lib.extract wrapper * Track column extractions via header * Fix analytics event name * Add tests for extract action analytics * Set up extractions metadata helper * Use functionsUseByExtraction in analytics * Add custom type for ExtractionTag * Use ExtractionTag in analytics * [MBQL lib] Add `Lib.columnExtractDrillExtractions` This gets the extractions from a column-extract drill, which is needed in the UI. * Add extractionExpression wrapper * Add extractionsForDrill helper * Fix type signature of extractionExpression * Use expressionParts for getting expression function * Walk expression to get functions used * Simplify ColumnExtractionTag * Fix expected expression * Be more explicit with what the guard does --------- Co-authored-by: Braden Shepherdson <braden@metabase.com>
* add TOC to Jetty article * add ToC for debian article * vvariables * Update docs/installation-and-operation/running-metabase-on-debian.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
…database metadata endpoint) (#42062) * add skip_fields flag to database metadata endpoint * skips loading fields on database metadata requests while on admin permissions pages --------- Co-authored-by: Sloan Sparger <sloansparger@gmail.com>
This is a new parameter `:type` (and `:widget-type`) to choose a time granularity (a `:temporal-unit`, eg. `month`, `day`, `day-of-week`) which should replace the unit on the target field for the parameter. The target field should be a breakout with a temporal type (date, datetime) that's compatible with the input unit. The value of the parameter should be a string or keyword naming one of the units: `"month"`, `:month`. Part of #42118.
* Cleanup parameters popover * Convert to ts * Drop comment * Convert dashboard-options to TS
…ng (#42131) * Window functions should use all breakouts except first for partitioning * Update the offset() test * Update tests * Rework how we use driver escape-alias in MLv2; fix Oracle * PR feedback * Test fixes 🔧
…t MBQL (#42087) * Fix LgeacyMetric/Segment macroexpansion with definitions using ancient MBQL 2 * Remove stray println * PR feedback
…7 methods/2 protocols) (#42070) * Simplified MetadataProvider protocol * Test fix * Ok make CachedMetadataProvider a separate schema again after all. * Consolidate the Metadata schemas * Clean Kondo warnings * Malli-ify the stuff in metabase.lib.metadata.protocols * Fix Kondo warnings * Test fix 🔧 * PR feedback
* Add test for email extractions * Fix swapped domain and host examples * Add tests for URL columns * Fix examples for shortcut too * Use arrow function instead of function
* Add helper to track column extractions * Track column extractions * Add text for column extraction * Pass correct extraction to trackColumnExtractViaShortcut
* Add snowplow event for column combine via header * Add test for snowplow event * Remove unnecessary within wrapper * Fix linting issues
The API/model schemas for dashboard parameters are general enough that they just work for this new type, which doesn't look very different from a value parameter right now. Part of #42118.
Lets the `ItemsTable` component have customizable columns. The logic for this is contained in `BaseItemsTable`. This is preliminary work for #41614 This doesn't introduce any new UI, but there is a unit test for the new logic. The main thing to check is whether the table on the collections page stills work correctly. Note how the columns adjust as you resize the viewport horizontally. (In fact, the columns will sometimes adjust as you close and open the sidebar, because the width they are paying attention to is the width of the area to the right of the sidebar.) Closes #41908
* Fix InteractiveQuestion loader show no question before loaded * Add tests * Unskip a test
…ts (#42043) * Rename "Line style" to "Line shape" * Add "line.style" viz setting * Add "line.size" viz setting * Apply new viz settings in line/area charts * Clean up `ChartSettings` test suite * Fix default values not applied * Add visual test * Add E2E test * Rework default values * Use constant S/M/L values for "line.size" setting
* Update readme adding more ways to run Metabase * Remove running from `master` because it could break * Update enterprise/frontend/src/embedding-sdk/README.md Co-authored-by: Alberto Perdomo <albertoperdomo@users.noreply.github.com> * Update disclaimer, makes it more obvious --------- Co-authored-by: Alberto Perdomo <albertoperdomo@users.noreply.github.com>
* use css modules instead of inline styles for cursor: default (#41644) * add toast notification after the feedback (#41575) * fix modal submit sending data while button says skip (#41784) * fix: it should not send the feedback if button says skip * add comment explaining why we check that getLastFeedbackCall() is undefined * embedding homepage analytics (#41725) * rename defaultTab -> initialTab * add events schema for embedding-homepage * fix stories * add analytics, e2e tests and fix typo in dismiss reason * copy embed_flow schema for better diff in the next commit * adds isExampleDashboard to trackStaticEmbedPublished * utm tags * fix bug of is_example_dashboard * better test names * refactor embed homepage status type * "() => {}" => "_.noop" * add "Setup embedding" to the admin setup checklist (#41638) * add setup embedding to the admin setup checklist * restore whitespace as it was before * i miss prettier (whitespace again) * Clean up check list for embedding Largely making a new entry for the embedding info just to fight long lines. `:embedding-homepage-dismissed-as-done` just made the maps really long. If we have a `:done?` under an `:embedding` keyword it reads much more naturally. Also, The previous diff was calling `boolean` on a var rather than invoking the var: ```clojure :embedding-app-origin (boolean embed.settings/embedding-app-origin) ;; ^^^^^^^^^^^^^^ needs to be (invoked) ``` --------- Co-authored-by: dan sutton <dan@dpsutton.com> * Change utm tags for embedding homepage links (#42042) * update utm tags * utm_media -> utm_content * add description to the checklist setup step (#42200) --------- Co-authored-by: dan sutton <dan@dpsutton.com>
#42207) * public metabase theme type * add tests for transforming embedding theme * export public types * load transformed theme override into theme provider * migrate font family inside theme configuration * add assertion for font family * update README to add font family in theme options * add font enum, fix tuple type and cleanup tests * color tuple argument name * use fill for colortuple
* updating the first section * updating the column header formatting screenshot * Typo * Update docs/questions/sharing/visualizations/table.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Update docs/questions/sharing/visualizations/table.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
now: ```clojure ❯ clj -M:"$ALIASES" Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/21.0.2-tem 2024-05-07 19:55:25,167 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB ``` no logs about recur targets unboxing
* allow customizable base font size * pass in fontSize in mantine theme * only apply font size if it exists
…ion (#42328) * attempt to type the return value of actions created by createThunkAction * use built in Awaited instead of custom AwaitedIfPromise
* Support custom font in SDK * Update component after merging master
Co-authored-by: Ryan Laurie <iethree@gmail.com>
…42052) * Dashboard Param Values Common Impl for Embedding/Preview Embedding Refactor the embedding api namespace to allow a bit of reuse between the embedding api and the embedding preview api. In some cases, the implementations are not identical (in terms of the shape of data expected/endpoints available), so this is a first step to making them the same. Related: https://www.notion.so/metabase/Make-embedding-preview-behave-consistently-with-actual-static-embeds-855353d8e5e8411d8164c7ac563c7d2f * Add a test to verify that preview-embed param-values endpoint works * Use preview embed endpoint and fix relevant tests * Add tests * Change name to reflect what actually happens in the function --------- Co-authored-by: Mahatthana Nomsawadi <mahatthana.n@gmail.com>
…edded questions (#42212) * prop to reserve height and use full height by default * require height to be passed * add default height based on viz type * default to 250px * reserve table height * remove memoization * rely on the card size defaults constant * multiply by a fixed constant * correct vis to viz
metabase-bot
bot
added
.Team/QueryProcessor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e508f6b...2427881.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.