Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Extraneous Style Props #42431

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

iethree
Copy link
Contributor

@iethree iethree commented May 8, 2024

Description

We're trying to minimize use of style props with UI Library components. This removes them from two components where they were unnecessary:

  1. ModelUploadModal

Screen Shot 2024-05-08 at 3 44 48 PM

  1. New Colleciton Dialog (in the entity picker)

Screen Shot 2024-05-08 at 3 44 38 PM

@iethree iethree requested a review from a team May 8, 2024 21:46
@iethree iethree self-assigned this May 8, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 8, 2024
@iethree iethree added the no-backport Do not backport this PR to any branch label May 8, 2024
Copy link

replay-io bot commented May 8, 2024

Status Complete ↗︎
Commit 560dce0
Results
⚠️ 5 Flaky
2476 Passed

@iethree iethree merged commit 0c1a1f5 into master May 8, 2024
123 of 142 checks passed
@iethree iethree deleted the remove-extraneous-styles-props branch May 8, 2024 23:39
Copy link

github-actions bot commented May 8, 2024

@iethree Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants