Fix flaky question management e2e test #42444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilmielnik
changed the title
kamilmielnik
added
the
backport
|
WiNloSt
reviewed
May 9, 2024
iethree
approved these changes
May 9, 2024
| @@ -135,7 +138,7 @@ describe( | |||
| cy.get("header").findByText(NEW_COLLECTION_NAME); | |||
| }); | |||
|
|
|||
| it("should be able to move models", () => { | |||
| it("should be able to move models", { tags: "@flaky" }, () => { | |||
|
@kamilmielnik Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
kamilmielnik
added a commit
that referenced
this pull request
May 9, 2024
* Fix flaky question management test * Update assertions order to reduce probability of a flake * Use explicit assertions * Change assertion order * Decrease flakiness
kamilmielnik
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Slack thread.
Examples of failed runs:
Description
When I run the stress test with 50 burn-in (which means 100 runs because the test is defined in a loop) it starts to flake at the end (after 80+ runs) - I suspect it's due to Cypress giving up (out of memory or something alike).
So I decided to run it 25x twice, and it looks green now.
Stress tests (this PR):
Stress test on
master, for comparison: https://github.com/metabase/metabase/actions/runs/9015446311