-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Browse] Improve model sorting #42493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rafpaf
added
the
no-backport
Do not backport this PR to any branch
label
May 9, 2024
— with
Graphite App
rafpaf
force-pushed
the
browse/sort-better
branch
from
May 10, 2024 15:38
9541a98
to
ec6c165
Compare
iethree
approved these changes
May 10, 2024
|
@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
uladzimirdev
pushed a commit
that referenced
this pull request
May 11, 2024
Ensures that models are sorted as follows in Browse models: * Models are sorted by collection, by default * When models are sorted by collection, they are secondarily sorted by name (so that models with the same collection path appear in alphabetic order)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that models are sorted as follows in Browse models: