Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browse] Improve model sorting #42493

Merged
merged 5 commits into from
May 10, 2024
Merged

[Browse] Improve model sorting #42493

merged 5 commits into from
May 10, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 9, 2024

Ensures that models are sorted as follows in Browse models:

  • Models are sorted by collection, by default
  • When models are sorted by collection, they are secondarily sorted by name (so that models with the same collection path appear in alphabetic order)

Copy link
Contributor Author

rafpaf commented May 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 9, 2024
@rafpaf rafpaf requested a review from a team May 9, 2024 23:55
@rafpaf rafpaf changed the title wip [Browse] Improve model sorting May 9, 2024
@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label May 9, 2024 — with Graphite App
@rafpaf rafpaf marked this pull request as ready for review May 10, 2024 15:40
Copy link

replay-io bot commented May 10, 2024

Status Complete ↗︎
Commit ec6c165
Results
⚠️ 4 Flaky
2480 Passed

@rafpaf rafpaf merged commit 17852e5 into master May 10, 2024
181 of 191 checks passed
@rafpaf rafpaf deleted the browse/sort-better branch May 10, 2024 18:46
Copy link

@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@rafpaf rafpaf added this to the 0.50 milestone May 10, 2024
uladzimirdev pushed a commit that referenced this pull request May 11, 2024
Ensures that models are sorted as follows in Browse models:

* Models are sorted by collection, by default
* When models are sorted by collection, they are secondarily sorted by name (so that models with the same collection path appear in alphabetic order)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants