Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE - Reverts to old "Array.from" polyfill, some of modules of liferay-portal were breaking using preset-env's builtIns #87

Closed
wants to merge 5 commits into from
Closed

DO NOT MERGE - Reverts to old "Array.from" polyfill, some of modules of liferay-portal were breaking using preset-env's builtIns #87

wants to merge 5 commits into from

Conversation

diegonvs
Copy link
Collaborator

No description provided.

@diegonvs diegonvs changed the base branch from master to develop September 10, 2018 20:58
@diegonvs diegonvs changed the title Reverts to old "Array.from" polyfill, some of modules of liferay-portal were breaking using preset-env's builtIns DO NOT MERGE - Reverts to old "Array.from" polyfill, some of modules of liferay-portal were breaking using preset-env's builtIns Sep 12, 2018
@jbalsas
Copy link
Contributor

jbalsas commented Sep 18, 2018

Hey @diegonvs, looks like this is taking us longer to get right... Do you think we could simply revert #86 so we can release the plugin versions safely and then rework on top of that?

@diegonvs
Copy link
Collaborator Author

diegonvs commented Sep 18, 2018 •
edited

Sure! toConsumableArray_ implementation on Babel 7 is using Symbol object on current implementation, we need provide a better way to solve this. But for while, I'm watching babel/babel#7597.

@diegonvs diegonvs closed this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diegonvs @jbalsas