Extract frontmatter parsing to metalsmith-matters plugin #169
Conversation
| mockFiles[file] = ret; | ||
| frontmatter(mockFiles); | ||
| ret = mockFiles[file]; | ||
| } |
There was a problem hiding this comment.
Note that here I'm interacting with the plugin directly rather than running it via ware. I'm not 100% sure whether that was the right choice or not, but it seems clean enough.
|
Also, it would be great if someone could look over my code over at https://github.com/Ajedi32/metalsmith-matters I've got pleany of experience with JavaScript, but this is my first time creating anything "real" for node. |
|
Mentioned in the other thread, but I'm going to opt not to do this for now. For what it's worth, the diff does feel really nice being able to nix those lines :) if it wasn't for the public API, unshifting on the ware stack would have been cool in Anyways, thanks for the idea and interest and effort! |
webketje
force-pushed
the
master
branch
2 times, most recently
from
629516e
to
9fd4b33
Compare
webketje
force-pushed
the
master
branch
2 times, most recently
from
9d899cc
to
2c5abda
Compare
Removes all code related to parsing frontmatter, and instead relies on the metalsmith plugin
metalsmith-mattersto provide that functionality.This PR does not change the public API of metalsmith. That's something I plan on doing in later PRs. (See #157 for my thoughts on that.)