Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITU G.650 minor changes #75

Merged
merged 3 commits into from
May 1, 2020
Merged

ITU G.650 minor changes #75

merged 3 commits into from
May 1, 2020

Conversation

anermina
Copy link
Contributor

@anermina anermina commented Apr 24, 2020

  • Separated an image into two sub-figures and changed cross-referencing in accordance to the new anchors.
  • Added one missing space.
  • Replaced false dashes (which were causing hash instead of dash generation in PDF) with regular ones.

@anermina anermina requested a review from ronaldtse April 24, 2020 23:48
@ronaldtse
Copy link
Contributor

@CAMOBAP795 can you have a look here? The build is failing due to:

[relaton-iso] ("ISO 19136") fetching...
164
bundler: failed to load command: metanorma (/usr/local/bundle/bin/metanorma)
165
NoMethodError: undefined method `empty?' for nil:NilClass
166
  /usr/local/bundle/gems/relaton-iso-0.11.0/lib/relaton_iso/hit_collection.rb:35:in `block in to_all_parts'
167
  /usr/local/bundle/gems/relaton-iso-0.11.0/lib/relaton_iso/hit_collection.rb:35:in `select'
168
  /usr/local/bundle/gems/relaton-iso-0.11.0/lib/relaton_iso/hit_collection.rb:35:in `to_all_parts'
169
  /usr/local/bundle/gems/relaton-iso-0.11.0/lib/relaton_iso/iso_bibliography.rb:159:in `isobib_results_filter'
170

@ronaldtse ronaldtse added this to In progress in Alexander Bobrikovich via automation Apr 25, 2020
@ronaldtse
Copy link
Contributor

(Thanks @anermina , the content is good!)

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Apr 30, 2020

@anermina please ignore the issue on windows it will be fixed on next release metanorma/chocolatey-metanorma#42

I have restarted the workflows and builds looks good

@CAMOBAP CAMOBAP assigned anermina and unassigned CAMOBAP Apr 30, 2020
@anermina
Copy link
Contributor Author

Thanks @CAMOBAP795 ! I'll have that on my mind.

@CAMOBAP CAMOBAP removed this from In progress in Alexander Bobrikovich May 1, 2020
@ronaldtse ronaldtse merged commit b184542 into master May 1, 2020
@ronaldtse ronaldtse deleted the g650_corrections branch May 1, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants