chore/hyper 1.1 upgrade #450
Conversation
|
Oh yeah, this is definitely a meaty one. :) I would say that we should move the builder code into a new directory ( Once that's sorted, and you've cleaned up some more of the leftover stuff (commented out code, print statements, etc) we can start talking through the actual changes. |
|
Sounds like a plan. That's the direction I was going to go. Now to find some more time. |
|
@tobz Took a shot at reorganizing the exporters. I removed the nested closures of the http exporter as some might find it easier to read. I need to revisit Cargo.toml. |
There was a problem hiding this comment.
Overall, this is looking really good. Some of the hyper stuff is unfortunate given how much more verbose it's gotten, but alas. :)
Left a bunch of cleanup comments, and I think once those are addressed, I can take one more pass since it was a lot to digest at first.
metrics-exporter-prometheus/tests/http_listener_integration_test.rs
Outdated
Show resolved
Hide resolved
evaneaston
force-pushed
the
chore/hyper-1.1-upgrade
branch
from
1d6e4fe
to
ee83f2e
Compare
|
@tobz Would you like me to rebase and --signoff on my stuff. It'll require a diverging force push. |
If that's cool with you, that'd be nice. Force pushing is fine. |
Updates the requirements on [hyper](https://github.com/hyperium/hyper) to permit the latest version. - [Release notes](https://github.com/hyperium/hyper/releases) - [Changelog](https://github.com/hyperium/hyper/blob/v0.14.28/CHANGELOG.md) - [Commits](hyperium/hyper@v0.14.0...v0.14.28) --- updated-dependencies: - dependency-name: hyper dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Evan Easton <evan@eeaston.com>
…through deprecations. Signed-off-by: Evan Easton <evan@eeaston.com>
- factor large PrometheusBuilder.build function into separate functions in separate modules for http listener and push gateway - add an http-listener integration test Signed-off-by: Evan Easton <evan@eeaston.com>
Signed-off-by: Evan Easton <evan@eeaston.com>
… of an exporter module Signed-off-by: Evan Easton <evan@eeaston.com>
Signed-off-by: Evan Easton <evan@eeaston.com>
- correct hack --feature-powerset failures Signed-off-by: Evan Easton <evan@eeaston.com>
- move peer address allow check into listener loop - only obtain peer_address.ip() if allowed_addresses Some - yank Arc<Inner> and just cline handle Signed-off-by: Evan Easton <evan@eeaston.com>
evaneaston
force-pushed
the
chore/hyper-1.1-upgrade
branch
from
ee83f2e
to
84babcc
Compare
- get_available_port
- rename of param
- remove uneeded block
tobz
added
C-exporter
|
@tobz I pushed the tweak to fix the workflow fail. |
|
@evaneaston Just noticed the merge to get up-to-date with I'll take a final pass shortly and hopefully get this merged today. I think it's close enough that it's good enough to merge, since there's a lot of other changes queued up for release and I'll likely be doing some stylistic cleanup to my own preferences anyways. |
tobz
added
the
S-awaiting-release
|
Released in Thanks again for your contribution! |
tobz
removed
the
S-awaiting-release
PrometheusBuilder.buildfunction into separate functions