Replace Konacha by Teaspoon #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving global variables stubed may cause errors when trying to stub them for the next test suite.
It is a JS testing tool that will take konacha's place. It has better features and stability. It should address issues running the JS tests though Puma webserver.
It is causing issues when running acceptance tests using Puma. Teaspoon is proving itself as a more stable solution for JS testing.
|
@vitorbaraujo @oliveiraMarcelo, would you like to proceed with this PR? |
|
We will put this issue in our backlog and attack it in a future sprint, is that ok? |
|
That's ok. Thanks. |
|
We'll be continuing this PR now. |
|
Actually, is there still anything to be done here besides a rebase? Teaspoon can already run all the JS tests as it is. |
|
If with the rebase the Travis build is fixed go ahead and open a new PR then I close this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may address the CI issues from #393