Fix CodeClimate and MetricFu issues #418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Cristiano <marceloabk@hotmail.com> Signed-off-by: Pedro Ivo <andradepedroivo@gmail.com>
The old create_and_redir function was not clear in its name about what it performed. The body of the method was also improved with smaller functions with better names. Signed-off-by: Pedro Ivo Andrade <andradepedroivo@gmail.com>
When creating or editing a metric configuration, HTML pages had same codes. To improve that, I've created partials, to improve code reusage. Signed-off-by: Pedro Ivo Andrade <andradepedroivo@gmail.com>
Signed-off-by: Marcelo Cristiano <marceloabk@hotmail.com>
Improve legibility and code duplication
This way there is only one partial to be rendered with given parameters for projects, repositories and reading groups
Remove duplication in Mezuro views
Signed-off-by: Kássia Catarine <kassia_catarine.15@hotmail.com>
…ignificant names Signed-off-by: Kássia Catarine <kassia_catarine.15@hotmail.com>
Signed-off-by: Kássia Catarine <kassia_catarine.15@hotmail.com>
Clean code refactor kassia
Clean code amoedo
Signed-off-by: Marcelo Cristiano <marceloabk@hotmail.com>
Clean code marcelo
Creating partial to eliminate duplicated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metric_configurations#newandmetric_configurations#editformsprojects,repositoriesandreading_groupslistsreading_groups_controller#create_and_redir