flashNow() zero hops by default #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Lieberman <dev@timdev.com>
Signed-off-by: Tim Lieberman <dev@timdev.com>
timdev
force-pushed
the
topic/flashnow-zero-hops-default
branch
from
43ae815
to
22aafb1
Compare
Signed-off-by: Tim Lieberman <dev@timdev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #8 in a way that does not preserve BC.
I've changed the signature for
flashNow()by changing the default value for the$hopsargument from one to zero.This means that messages set with
flashNow()are now visible only in the current request by default. Users who want such messages to persist beyond the current request can pass a positive integer top$hops.