Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor a parameter for SetCellUsing and SetPropertyUsing #213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andywu188
Copy link
Contributor

  1. Solve the problem that SetCellUsing and SetPropertyUsing parameters are not named and ambiguous.
  2. Improved support for parameters that can perform multiple property value calculations

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (1ecae95) to head (3225253).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   94.29%   95.27%   +0.97%     
==========================================
  Files          11       13       +2     
  Lines        1384     1417      +33     
  Branches      203      203              
==========================================
+ Hits         1305     1350      +45     
+ Misses         51       39      -12     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mganss
Copy link
Owner

mganss commented Aug 26, 2022

Thanks. There are some uncovered lines still, though.

@andywu188
Copy link
Contributor Author

already updated

@andywu188
Copy link
Contributor Author

I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete.

@mganss
Copy link
Owner

mganss commented Aug 26, 2022

I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete.

Can you add this to the PR?

@andywu188
Copy link
Contributor Author

already updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants