Skip to content

Commit

Permalink
fix(rules): log parse errors and fix noUnusedCss
Browse files Browse the repository at this point in the history
Fix #227
  • Loading branch information
mgechev committed Feb 19, 2017
1 parent 84260b6 commit 19fdabf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -9,7 +9,7 @@
"copy:common": "cp README.md dist",
"build:links": "ts-node build/links.ts --src ./dist",
"prepare:package": "cat package.json | ts-node build/package.ts > dist/package.json",
"test": "rimraf dist && tsc && cp -r test/fixtures dist/test && mocha dist/test --recursive",
"test": "rimraf dist && tsc && cp -r test/fixtures dist/test && BUILD_TYPE=dev npm run set:vars && mocha dist/test --recursive",
"test:watch": "rimraf dist && tsc && cp -r test/fixtures dist/test && BUILD_TYPE=dev npm run set:vars && mocha dist/test --watch --recursive",
"set:vars": "ts-node build/vars.ts --src ./dist",
"tscv": "tsc --version",
Expand Down
4 changes: 2 additions & 2 deletions src/angular/ng2Walker.ts
Expand Up @@ -133,7 +133,7 @@ export class Ng2Walker extends Lint.RuleWalker {
const templateAst = parseTemplate(template.template.code, Config.predefinedDirectives);
this.visitNg2TemplateHelper(templateAst, metadata, getPosition(template.node));
} catch (e) {
logger.error('Cannot parse the template of', ((<any>metadata.controller || {}).name || {}).text);
logger.error('Cannot parse the template of', ((<any>metadata.controller || {}).name || {}).text, e);
}
}
const styles = metadata.styles;
Expand All @@ -143,7 +143,7 @@ export class Ng2Walker extends Lint.RuleWalker {
try {
this.visitNg2StyleHelper(parseCss(style.style.code), metadata, style, getPosition(style.node));
} catch (e) {
logger.error('Cannot parse the styles of', ((<any>metadata.controller || {}).name || {}).text);
logger.error('Cannot parse the styles of', ((<any>metadata.controller || {}).name || {}).text, e);
}
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/noUnusedCssRule.ts
Expand Up @@ -19,7 +19,10 @@ import {logger} from './util/logger';
const CssSelectorTokenizer = require('css-selector-tokenizer');

const getSymbolName = (t: any) => {
let expr = t.expression;
let expr = t;
if (t.expression) {
expr = t.expression;
}
if (t.expression && t.expression.name) {
expr = t.expression.name;
}
Expand Down

0 comments on commit 19fdabf

Please sign in to comment.