fix: report errors when bound to private in ngFor

Fix #306

src/angular/config.ts

@@ -73,6 +73,7 @@ export const Config: Config = {
     { selector: '[md-tooltip], [mat-tooltip], [mdTooltip]', exportAs: 'mdTooltip' },
     { selector: 'md-select, mat-select', exportAs: 'mdSelect' },
     { selector: '[ngIf]', exportAs: 'ngIf', inputs: ['ngIf'] },
+    { selector: '[ngFor][ngForOf]', exportAs: 'ngFor', inputs: ['ngForTemplate', 'ngForOf'] },
     { selector: '[ngSwitch]', exportAs: 'ngSwitch', inputs: ['ngSwitch'] }
   ],
 

src/angular/templates/basicTemplateAstVisitor.ts

@@ -51,7 +51,7 @@ const getExpressionDisplacement = (binding: any) => {
     totalLength = binding.sourceSpan.end.offset - binding.sourceSpan.start.offset;
     // The whitespace are possible only in:
     // `[foo.bar]          =         "...."`,
-    // and they are verything except the attrLen and the valLen (-1 because of the close quote).
+    // and they are everything except the attrLen and the valLen (-1 because of the close quote).
     let whitespace = totalLength - (attrLen + valLen) - 1;
     // The resulted displacement is the length of the attribute + the whitespaces which
     // can be located ONLY before the value (the binding).
@@ -99,12 +99,12 @@ export class BasicTemplateAstVisitor extends SourceMappingVisitor implements ast
   visitNgContent(ast: ast.NgContentAst, context: any): any {}
 
   visitEmbeddedTemplate(ast: ast.EmbeddedTemplateAst, context: any): any {
+    ast.directives.forEach(d => this.visit(d, context));
     ast.variables.forEach(v => this.visit(v, context));
     ast.children.forEach(e => this.visit(e, context));
     ast.outputs.forEach(o => this.visit(o, context));
     ast.attrs.forEach(a => this.visit(a, context));
     ast.references.forEach(r => this.visit(r, context));
-    ast.directives.forEach(d => this.visit(d, context));
   }
 
   visitElement(element: ast.ElementAst, context: any): any {

src/templatesUsePublicRule.ts

@@ -83,7 +83,7 @@ export class Rule extends Lint.Rules.AbstractRule {
     ruleName: 'templates-use-public-rule',
     type: 'functionality',
     description: `Ensure that properties and methods accessed from the template are public.`,
-    rationale: `When Angular compiles the templates, it has to access these propertes from outside the class.`,
+    rationale: `When Angular compiles the templates, it has to access these properties from outside the class.`,
     options: null,
     optionsDescription: `Not configurable.`,
     typescriptOnly: true,

test/templatesUsePublicRule.spec.ts

@@ -192,7 +192,7 @@ describe('templates-use-public', () => {
         assertSuccess('templates-use-public', source);
     });
 
-    it.only('should succeed shadowed variable', () => {
+    it('should succeed shadowed variable', () => {
       let source = `
         @Component({
           selector: 'foobar',
@@ -207,5 +207,49 @@ describe('templates-use-public', () => {
         }`;
       assertSuccess('templates-use-public', source);
     });
+
+    // Angular doesn't provide the correct source span of the property.
+    it('should fail when private property used in *ngFor', () => {
+      let source = `
+        @Component({
+          selector: 'foobar',
+          template: \`
+            <div *ngFor="let smile of smile2">
+            ~~~~~~
+              <smile-cmp [smile]="smile"></smile-cmp>
+            </div>
+          \`
+        })
+        class Test {
+          private smile2: any;
+        }`;
+      assertAnnotated({
+        ruleName: 'templates-use-public',
+        message: 'You can bind only to public class members. "smile2" is not a public class member.',
+        source
+      });
+    });
+
+    // Angular doesn't provide the correct source span of the property.
+    it('should fail when private property used in *ngFor', () => {
+      let source = `
+        @Component({
+          selector: 'foobar',
+          template: \`
+            <div *ngFor="let smile of smile">
+            ~~~~~
+              <smile-cmp [smile]="smile"></smile-cmp>
+            </div>
+          \`
+        })
+        class Test {
+          private smile: any;
+        }`;
+      assertAnnotated({
+        ruleName: 'templates-use-public',
+        message: 'You can bind only to public class members. "smile" is not a public class member.',
+        source
+      });
+    });
   });
 });