fixup! improve ngWalker by preventing an error when a class has no name.

mgechev · Mar 10, 2019 · a9aeed5 · a9aeed5
1 parent c9786b2
commit a9aeed5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/angular/metadataReader.ts b/src/angular/metadataReader.ts
@@ -97,9 +97,9 @@ export class MetadataReader {
     const name = nameExpression && isStringLiteralLike(nameExpression) ? nameExpression.text : undefined;
 
     const pureExpression = getDecoratorPropertyInitializer(dec, 'pure');
-    const isBoolean = pureExpression && isBooleanLiteralLike(pureExpression);
+    const pure = pureExpression && isBooleanLiteralLike(pureExpression) ? pureExpression : undefined;
 
-    return new PipeMetadata(d, dec, name, isBoolean ? (pureExpression as ts.BooleanLiteral) : undefined);
+    return new PipeMetadata(d, dec, name, pure);
   }
 
   protected readModuleMetadata(d: ts.ClassDeclaration, dec: ts.Decorator): DirectiveMetadata {

diff --git a/src/noPipeImpureRule.ts b/src/noPipeImpureRule.ts
@@ -38,8 +38,7 @@ export class ClassMetadataWalker extends NgWalker {
   }
 
   private validatePipe(metadata: PipeMetadata): void {
-    if (!metadata.pure) return;
-    if (metadata.pure!.kind !== SyntaxKind.FalseKeyword) return;
+    if (!metadata.pure || metadata.pure.kind !== SyntaxKind.FalseKeyword) return;
 
     const className = getClassName(metadata.controller)!;