fix: proper check for public members

Fix #206
mgechev · Dec 31, 2016 · cc3ed9a · cc3ed9a
1 parent 5a012d7
commit cc3ed9a
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 4 deletions.
diff --git a/src/templatesUsePublicRule.ts b/src/templatesUsePublicRule.ts
@@ -37,10 +37,8 @@ class SymbolAccessValidator extends RecursiveAngularExpressionVisitor {
     const allMembers = getDeclaredMethods(this.context.controller).concat(getDeclaredProperties(this.context.controller));
     const member = allMembers.filter((m: any) => m.name && m.name.text === ast.name).pop();
     if (member) {
-      let isPublic = !member.modifiers;
-      if (member.modifiers) {
-        isPublic = member.modifiers.some(m => m.kind === SyntaxKind.current().PublicKeyword);
-      }
+      let isPublic = !member.modifiers || !member.modifiers
+        .some(m => m.kind === SyntaxKind.current().PrivateKeyword || m.kind === SyntaxKind.current().ProtectedKeyword);
       const width = ast.name.length;
       if (!isPublic) {
         const failureString = 'You can bind only to public class members.';

diff --git a/test/noAccessMissingMemberRule.spec.ts b/test/noAccessMissingMemberRule.spec.ts
@@ -723,6 +723,27 @@ describe('no-access-missing-member', () => {
         }`;
         assertSuccess('no-access-missing-member', source);
     });
+
+
+//    it('should succeed with array element access', () => {
+//      let source = `
+//        @Component({
+//          template: '<div *ngIf="context"></div>'
+//        })
+//        class Test {
+//        }`;
+//        assertFailure('no-access-missing-member', source, {
+//          message: 'The property "context" that you\'re trying to access does not exist in the class declaration.',
+//          startPosition: {
+//            line: 2,
+//            character: 23
+//          },
+//          endPosition: {
+//            line: 2,
+//            character: 24
+//          }
+//        });
+//    });
 //    TODO
 //    it('should work with getters', () => {
 //      let source = `

diff --git a/test/templatesUsePublicRule.spec.ts b/test/templatesUsePublicRule.spec.ts
@@ -209,5 +209,18 @@ describe('templates-use-public', () => {
         }`;
         assertSuccess('templates-use-public', source);
     });
+
+
+    it('should succeed on public nested props', () => {
+      let source = `
+        @Component({
+          selector: 'foobar',
+          template: '<div>{{ foo }}</div>
+        })
+        class Test {
+          readonly foo: any;
+        }`;
+        assertSuccess('templates-use-public', source);
+    });
   });
 });