Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): update the CSS parser #482

Merged
merged 4 commits into from Jan 9, 2018
Merged

fix(core): update the CSS parser #482

merged 4 commits into from Jan 9, 2018

Conversation

mgechev
Copy link
Owner

@mgechev mgechev commented Jan 8, 2018

Fix #446

@mgechev mgechev requested a review from wKoza January 8, 2018 08:55
@wKoza
Copy link
Collaborator

wKoza commented Jan 8, 2018

Good refactoring ! this parser needed it ;)
can you add a test to check that parsing no longer blocks ?

@mgechev
Copy link
Owner Author

mgechev commented Jan 8, 2018

@wKoza good catch...the issue still persists in the parser. Trying to figure out where exactly.

@mgechev
Copy link
Owner Author

mgechev commented Jan 8, 2018 •
edited

@wKoza I'll push the fix upstream as well.

wKoza
wKoza approved these changes Jan 9, 2018
View reviewed changes
Copy link
Collaborator

@wKoza wKoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wKoza wKoza merged commit 9c90ac3 into master Jan 9, 2018
@mgechev mgechev deleted the minko/css-parser branch January 9, 2018 11:05
@mgechev
Copy link
Owner Author

mgechev commented Jan 9, 2018

CssParser is a module which Angular doesn't use internally. It's not part of the compiler bundle. We might be the only ones using it.

mgechev added a commit that referenced this pull request Jan 16, 2018
@mgechev
Merge branch 'master' of github.com:mgechev/codelyzer
bd8386b 
* 'master' of github.com:mgechev/codelyzer:
  fix(i18n): do not warn with interpolation in i18n element (#485)
  fix(trackBy): fix rule when ngFor statements include let assignments (#483)
  fix(core): update the CSS parser (#482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wKoza wKoza wKoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgechev @wKoza