Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-output-on-prefix): fix regular expression #674

Merged
merged 3 commits into from Jun 24, 2018
Merged

fix(no-output-on-prefix): fix regular expression #674

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8159a35
fix(no-output-on-prefix): fix regular expression
loktionov129 Jun 24, 2018
528851c
test(no-output-on-prefix): add more test cases
loktionov129 Jun 24, 2018
0ea7a1b
style(no-output-on-prefix): fix misspellings
loktionov129 Jun 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/noOutputOnPrefixRule.ts
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@ class OutputWalker extends NgWalker {
const className = getClassName(property);
const memberName = property.name.getText();

if (!memberName || !/on((?![a-z])|(?=$))/.test(memberName)) {
if (!memberName || !/^on((?![a-z])|(?=$))/.test(memberName)) {
return;
}

Expand Down
12 changes: 12 additions & 0 deletions test/noOutputOnPrefixRule.spec.ts
View file
Open in desktop
Expand Up @@ -69,4 +69,16 @@ describe('no-output-on-prefix', () => {
assertSuccess('no-output-on-prefix', source);
});
});

describe('valid output property name', () => {
it("should succeed, when a output property containing 'on' suffix", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a -> an. Also, you can put this test in the above describe.

const source = `
@Component()
class SelectComponent {
@Output() selectionChanged = new EventEmitter<any>();
}
`;
assertSuccess('no-output-on-prefix', source);
});
});
});