refactor: bump packages versions #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will take a while to review. It'll be very helpful if you can separate it into multiple PRs or at least multiple commits so I can review them in a sequence? |
|
Done, @mgechev. |
|
Wow, that was fast! :) |
mgechev
reviewed
Mar 4, 2019
src/noInputRenameRule.ts
Outdated
| @@ -90,17 +92,15 @@ export class InputMetadataWalker extends NgWalker { | |||
| (propertyAlias !== propertyName && | |||
| this.directiveSelectors && | |||
| this.directiveSelectors.some(x => new RegExp(`^${x}((${toTitleCase(propertyName)}$)|(?=$))`).test(propertyAlias))) || | |||
| (whiteListAliases.has(propertyAlias) && propertyName === kebabToCamelCase(propertyAlias)) | |||
| (whiteListAliases.has(propertyAlias) && propertyName === camelize(propertyAlias)) | |||
There was a problem hiding this comment.
kebabToCamelCase is more semantically correct. We will not be able to camelize an arbitrary string. Would you mind reverting this name change?
There was a problem hiding this comment.
No problem. I did it because I saw that TSLint has already a function to camelize strings.
mgechev
approved these changes
Mar 4, 2019
|
@rafaelss95 thanks for updating the AST traversal from visitors to functions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we maintain 2
lockfiles, but once you try to executeyarnwithyarn.lockandpackage-lock.json, you get the following message:To fix this, I've decided to remove the
package-lock.json. If you prefer to usenpm, we can removeyarn.lockinstead.Summary:
Removed unused packages:
@types/less;minimalist;Packages that can't be updated because break the rules/tests:
chai-spies;source-map;Move git hooks from package.json to
.huskyrc.jsonfile.Since TSLint is also being upgraded, some rules, which extends
RuleWalkerdirectly, were reworked to useWalkContextinstead (About RuleWalker #777).NgWalkerandSourceMappingVisitorextendstheRuleWalkerand for now thedeprecationrule for theextendsline was just disabled.Some Typescript errors are caught by the newer version and fixed properly.
The tests are green ✅