Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rule): template-banana-in-box regex failing in some environments #820

Merged
merged 3 commits into from May 1, 2019
Merged

fix(rule): template-banana-in-box regex failing in some environments #820

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4387c62
fix(rule): template-banana-in-box regex failing in some environments
rafaelss95 Apr 26, 2019
67745f8
Merge branch 'master' into fix/template-banana-in-box
mgechev Apr 29, 2019
4f60442
Merge branch 'master' into fix/template-banana-in-box
mgechev May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/templateBananaInBoxRule.ts
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ import { SourceFile } from 'typescript';
import { NgWalker, NgWalkerConfig } from './angular/ngWalker';
import { BasicTemplateAstVisitor } from './angular/templates/basicTemplateAstVisitor';

const INVALID_BOX = /^\[(?!\()(.*)(?<!\))\]$/;
const INVALID_PATTERN = /\[(.*)\]/;
const VALID_CLOSE_BOX = ')]';
const VALID_OPEN_BOX = '[(';

Expand Down Expand Up @@ -38,7 +38,7 @@ class TemplateVisitorCtrl extends BasicTemplateAstVisitor {
}

private validateEvent(ast: BoundEventAst): void {
const matches = ast.name.match(INVALID_BOX);
const matches = ast.name.match(INVALID_PATTERN);

if (!matches) return;

Expand Down