Allow to provide drupal_root via an environment variable. #702
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests are currently failing on |
mglaman
reviewed
Jan 31, 2024
Comment on lines
-88
to
89
| $drupalRoot = realpath($drupalParams['drupal_root']); | ||
| $drupalRoot = realpath(getenv('DRUPAL_ROOT') !== false ? getenv('DRUPAL_ROOT') : $drupalParams['drupal_root']); | ||
| $finder = new DrupalFinder(); |
There was a problem hiding this comment.
So this would add a new environment variable called DRUPAL_ROOT that can be defined? I wonder, since bootstrap.inc is included via Composer's autoloading if we should use the DRUPAL_ROOT constant.
But I don't know if I want to rely on that global constant. It's preferred to use app.root container parameter (which we cannot use.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps in cases when PHPStan is called outside of the main website location.