Adding new rule for checking controller autowire #751
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshirohit100
force-pushed
the
issue-750
branch
from
62ea2c8
to
8947743
Compare
joshirohit100
force-pushed
the
issue-750
branch
from
8947743
to
cb69616
Compare
mglaman
requested changes
May 5, 2024
Comment on lines
58
to
64
| $namespace = $class->namespacedName->toCodeString(); | ||
| $reflection = $this->reflectionProvider->getClass($namespace); | ||
| $extends_controllerbase = $reflection->isSubclassOf('Drupal\Core\Controller\ControllerBase'); | ||
|
|
||
| if (!$extends_controllerbase) { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
This should check if the auto wire trait is used versus the specific base class
There was a problem hiding this comment.
Updated to check for the trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #750