Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query_string option to append params #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keslert
Copy link

@keslert keslert commented Aug 13, 2020

Forked from #91. Solves #89 and #70.

@nkezhaya
Copy link

@keslert @minibikini This has a pretty critical bug in it. On line 349 you're calling |> String.replace(~r/&?page=\d/, ""), which doesn't account for page numbers with multiple digits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants