New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phoenix dep, Application boundaries for Elixir 1.11.x #104

Open

tmartin8080 wants to merge 2 commits into mgwidmann:master from tmartin8080:application_boundries

tmartin8080 commented Jan 17, 2021 •

edited

There are some application boundary warnings for Elixir 1.11.x and some other misc changes.

After updating, there were some failing tests which seem to be related to generating a tags:

 [60, "a", [[32, "class", 61, 34, "", 34]], 62, "1", 60, 47, "a", 62],
 [60, "a", [[32, "class", 61, 34, [], 34]], 62, "1", 60, 47, "a", 62],

I'll look more into this, but wanted to get a PR started.
Free to to chime in on what the implications of [] vs "" might be.

tmartin8080 added 2 commits

January 17, 2021 10:52


          Relax deps and add application boundries

75218eb


          Adjust tests

621012c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment