Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespaces not handled by black #2222

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Mar 24, 2024

And use ruff to prevent regressions

And use ruff to prevent regressions
ruff.toml Outdated

[lint.per-file-ignores]
# TODO: Make adodbapi changes in their own PRs
"adodbapi/*" = ["W"]
Copy link
Collaborator Author

@Avasam Avasam Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #2224

@mhammond
Copy link
Owner

I'm actually skipping most of these PRs which introduce ruff into CI, just because I want to think that through some more - as I'm sure you have discovered, I'm not a big fan of overly officious CI, and not entirely convinced issues like trailing whitespace are a such a problem they are worth solving with a big stick.

@Avasam
Copy link
Collaborator Author

Avasam commented May 10, 2024

@mhammond moving these additional checks to #2221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants