Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer more f-strings and non-printf-style format #2223

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Mar 24, 2024

Follow-up to #2122

Done by running ruff check --fix --select=ISC,FLY,G,UP --ignore=ISC003,UP015,UP038

ruff.toml Outdated

[lint.per-file-ignores]
# TODO: Make adodbapi changes in their own PRs
"adodbapi/*" = ["UP"]
Copy link
Collaborator Author

@Avasam Avasam Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #2086, #2088 and indirectly #2098 since it removes a lot of code.

ruff.toml Outdated

[lint.per-file-ignores]
# TODO: Make adodbapi changes in their own PRs
"adodbapi/*" = ["ISC", "UP"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #2094

Run updated f-string format checks
Use ruff to prevent regressions
And a few manual changes needed for checks to pass
@Avasam Avasam requested a review from mhammond May 10, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant