Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate axscript.client.error module and remove redundant code #2236

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Mar 30, 2024

Built on top of https://github.com/mhammond/pywin32/pull/2235/files#r1545016331 and #2211

  • Annotated all params in axscript.client.error
  • Fixed type issues
  • Update code to not rely on tuple length (also closes Error processing SyntaxError exception from a Python Script #2233 )
  • Removed redundant exc_type and tb params that can be extracted from the error itself.
    • To retain backwards compatibility, I've left the params in AXScriptException.__init__ with a DeprecationWarning since it's public. (if you think this shouldn't have been called directly by any user code, then I can remove the parameters entirely)

I'm not sure what the assignements to None I removed were doing, please let me know if and how they were important.

@Avasam Avasam marked this pull request as draft March 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error processing SyntaxError exception from a Python Script
1 participant