Test against all supported versions of mocha #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are reports (michaelleeallen#148) of mocha-junit-reporter not working against certain versions of mocha. We really need to test more than one version of mocha to ensure that doesn't happen.
gabegorelick
commented
Oct 9, 2021
| @@ -28,7 +28,15 @@ | |||
| "chai": "^3.0.0", | |||
| "chai-xml": "^0.3.0", | |||
| "eslint": "^7.0.0", | |||
| "mocha": "^7.2.0", | |||
| "mocha": "^9.1.2", | |||
There was a problem hiding this comment.
This is the version of mocha used when CI runs node_modules/.bin/mocha.
gabegorelick
commented
Oct 9, 2021
| @@ -151,7 +153,7 @@ describe('mocha-junit-reporter', function() { | |||
|
|
|||
| // We don't want Mocha to emit timeout errors. | |||
| // If we want to simulate errors, we'll emit them ourselves. | |||
| rootSuite.enableTimeouts(false); | |||
| rootSuite.timeout(0); | |||
There was a problem hiding this comment.
gabegorelick
commented
Oct 9, 2021
| // Otherwise, this runner would intercept uncaught exceptions that were already handled by the mocha instance | ||
| // running our tests. | ||
| runner.dispose(); | ||
| if (runner.dispose) { |
There was a problem hiding this comment.
.dispose() isn't available in older versions of mocha.
clayreimann
approved these changes
Oct 14, 2021
gabegorelick
added a commit
to gabegorelick/mocha-junit-reporter
that referenced
this pull request
Oct 14, 2021
Introduced by michaelleeallen#157. No idea how that build passed.
|
It looks like this is causing the build to fail (https://github.com/michaelleeallen/mocha-junit-reporter/runs/3895617023) due to a Anyway here's a tentative fix: #159 |
gabegorelick
added a commit
to gabegorelick/mocha-junit-reporter
that referenced
this pull request
Oct 14, 2021
Introduced by michaelleeallen#157. No idea how that build passed.
gabegorelick
added a commit
to gabegorelick/mocha-junit-reporter
that referenced
this pull request
Oct 14, 2021
Introduced by michaelleeallen#157. No idea how that build passed.
gabegorelick
added a commit
to gabegorelick/mocha-junit-reporter
that referenced
this pull request
Oct 14, 2021
Introduced by michaelleeallen#157. No idea how that build passed.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are reports (#148) of mocha-junit-reporter not working against certain versions of mocha. We really need to test more than one version of mocha to ensure that doesn't happen.