Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 修复react 17以下使用shadow dom事件捕获错误 #381

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

asiainfoliwei
Copy link

feat: 修复react 17以下使用shadow dom事件捕获错误

@bailicangdu
Copy link
Member

其他框架下都测试过吗

@bailicangdu
Copy link
Member

比如vue子应用开启shadowDom,添加到document的事件是否会失效?

@asiainfoliwei
Copy link
Author

比如vue子应用开启shadowDom,添加到document的事件是否会失效?

我理解开启shadowDom其实本身应该也是自成一个环境吧,代理到shadowRoot上好像没啥问题,如果要穿透的话可以用其他方法

@bailicangdu
Copy link
Member

不排除子应用需要监听document事件的情况,尤其是对于第三方ui库中的组件,为了解决一个问题,会引入另外的问题

@asiainfoliwei
Copy link
Author

不排除子应用需要监听document事件的情况,尤其是对于第三方ui库中的组件,为了解决一个问题,会引入另外的问题

是的,这个就是一个取舍了,我这边的痛点是,react 16.x相关事件都不相应,其实我感觉这种是不能两全的,或者可以这样,我们可以提供一个配置选项来判断是否开启这个功能。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants