Typecheck the tests in CI. (#470)

Neither CRA's build nor test steps do this.

Fix various minor typing errors to get this clean again.

facebook/create-react-app#5626

package.json

@@ -73,12 +73,13 @@
   "scripts": {
     "bundle-size-explorer": "source-map-explorer 'build/static/js/*.js'",
     "bundle-size-report": "source-map-explorer 'build/static/js/*.js' --html reports/bundle-size.html",
-    "ci": "npm run test && npm run build && npm run bundle-size-report",
+    "ci": "npm run typecheck && npm run test && npm run build && npm run bundle-size-report",
     "start": "craco start",
     "build": "craco build",
     "test": "craco test --testPathIgnorePatterns=e2e",
     "eject": "craco eject",
     "serve": "npx serve --no-clipboard -l 3000 -- build/",
+    "typecheck": "tsc --noEmit",
     "test:all": "craco test --testTimeout 15000",
     "test:e2e": "craco test --testPathPattern e2e -w 1 --testTimeout 15000",
     "test:e2e:headless": "CI=true npm run test:e2e",

src/common/sanity.ts

@@ -12,5 +12,5 @@ export interface PortableTextBlock {
 }
 
 export type PortableText = Array<
-  PortableTextBlock | { _type: string; children?: any }
+  PortableTextBlock | { _type: string; children?: any; [other: string]: any }
 >;

src/documentation/common/DocString.test.tsx

@@ -4,7 +4,6 @@
  * SPDX-License-Identifier: MIT
  */
 import { render } from "@testing-library/react";
-import { renderMarkdown } from "../editor/codemirror/language-server/documentation";
 import DocString from "./DocString";
 
 describe("DocString", () => {

src/documentation/explore/ToolkitContent.test.tsx

@@ -11,12 +11,12 @@ jest.mock("@chakra-ui/image", () => ({
 
 import { ImageProps } from "@chakra-ui/react";
 import { render } from "@testing-library/react";
-import { ToolkitPortableText } from "./model";
-import ToolkitContent, { imageUrlBuilder } from "./ToolkitContent";
+import { PortableText } from "../../common/sanity";
+import ToolkitContent from "./ToolkitContent";
 
 describe("ToolkitContent", () => {
   it("renders external links", () => {
-    const content: ToolkitPortableText = [
+    const content: PortableText = [
       {
         _key: "aa98d45c4830",
         _type: "block",
@@ -51,7 +51,7 @@ describe("ToolkitContent", () => {
   });
 
   it("renders images", () => {
-    const content: ToolkitPortableText = [
+    const content: PortableText = [
       {
         _type: "simpleImage",
         alt: "micro:bit showing X axis going across the front, Y axis going down and up, Z axis going back to front",

src/documentation/search/blocks-to-text.test.ts

@@ -3,10 +3,10 @@
  *
  * SPDX-License-Identifier: MIT
  */
+import { PortableText } from "../../common/sanity";
 import { blocksToText } from "./blocks-to-text";
-import { ToolkitPortableText } from "../explore/model";
 
-const content: ToolkitPortableText[] = [
+const content: PortableText[] = [
   [
     {
       _key: "41931367cb0c",

src/fs/storage.test.ts

@@ -12,6 +12,8 @@ import {
   SplitStrategyStorage,
 } from "./storage";
 
+const projectName = "projectName";
+
 const commonStorageTests = (storage: FSStorage) => {
   it("is empty", async () => {
     expect(await storage.ls()).toEqual([]);
@@ -67,7 +69,7 @@ describe("SessionStorageFSStorage", () => {
 });
 
 describe("InMemoryFSStorage", () => {
-  const storage = new InMemoryFSStorage();
+  const storage = new InMemoryFSStorage(projectName);
   beforeEach(() => {
     storage.clear();
   });
@@ -76,7 +78,7 @@ describe("InMemoryFSStorage", () => {
 
 describe("SplitStrategyStorage", () => {
   const storage = new SplitStrategyStorage(
-    new InMemoryFSStorage(),
+    new InMemoryFSStorage(projectName),
     new SessionStorageFSStorage(sessionStorage),
     new NullLogging()
   );
@@ -88,7 +90,7 @@ describe("SplitStrategyStorage", () => {
   commonStorageTests(storage);
 
   it("initializes from session storage", async () => {
-    const memory = new InMemoryFSStorage();
+    const memory = new InMemoryFSStorage(projectName);
     const session = new SessionStorageFSStorage(sessionStorage);
     session.write("test1.py", new Uint8Array([1]));
 
@@ -98,7 +100,7 @@ describe("SplitStrategyStorage", () => {
   });
 
   it("clears and stops using session storage if we hit errors", async () => {
-    const memory = new InMemoryFSStorage();
+    const memory = new InMemoryFSStorage(projectName);
     const session = new SessionStorageFSStorage(sessionStorage);
 
     const log = new MockLogging();