Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright #1153

Merged
merged 38 commits into from
Mar 19, 2024
Merged

Playwright #1153

merged 38 commits into from
Mar 19, 2024

Conversation

microbit-grace
Copy link
Contributor

No description provided.

@microbit-grace
Initialise playwright
6c6f66e 
Done by running `npm init playwright@latest`.
Install playwright and added some example tests
@microbit-grace
Downgrade to @playwright/test v1.30.0
e4a67b0 
Otherwise there is a Node error
@microbit-grace
Configure Playwright
3b1e7f4 
- remove comments
- only run test in Chromium browser
- use testDir to ./src/e2e
- run local server before starting tests
@microbit-grace
Upgrade playwright/test to v1.32.0
dadd592 
so that we can use `npx playwright test --ui` for dev
@microbit-grace
Add settings.spec.ts
0f212a5
@microbit-grace
Add reset.spec.ts
be55bc4
@microbit-grace
Add more test files WIP
09f20ab
@github-actions GitHub Actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/playwright-main/

microbit-grace
microbit-grace commented Mar 19, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@microbit-grace microbit-grace changed the title [WIP] Playwright Playwright Mar 19, 2024
@microbit-grace microbit-grace marked this pull request as ready for review March 19, 2024 13:00
microbit-matt-hillsdon
microbit-matt-hillsdon requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you move playwright from package.json dependencies to dev dependencies and remove puppeteer and related packages?

Some other comments inline.

@microbit-grace
Copy link
Contributor Author

microbit-grace commented Mar 19, 2024 •
edited

Please can you move playwright from package.json dependencies to dev dependencies and remove puppeteer and related packages?

I removed puppeteer and related packages c580a85, and removed playwright d6ea1ee.
It didn't seem like I needed it for dev

microbit-matt-hillsdon
microbit-matt-hillsdon approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 4249e11 into main Mar 19, 2024
1 check passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the playwright-main branch March 19, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-matt-hillsdon microbit-matt-hillsdon microbit-matt-hillsdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@microbit-grace @microbit-matt-hillsdon