Add Css Styling for element attributes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style policies allow inline styles ("style" attributes on HTML elements) to be processed, either using regular expressions or matching against a list of allowed values (enum).
Adds a test for AllowStyles which covers Matching, MatchingEnum, OnElements and Globally.
This change adds in default handlers and functionality to add handlers to specific styles. Building on top of Nicholls changes, this allows for setting allowed styles as an attribute of either individual elements or globally and validating using either a regular expression, matching against a list of values, or with a supplied handler. If none of these are supplied, it relies on a default handler for each element. Please note this change does not allow for style elements, or for external styule sheets.
|
Attempted fix to #43 |
buro9
reviewed
Jul 15, 2019
| @@ -228,7 +232,7 @@ func (p *Policy) sanitize(r io.Reader) *bytes.Buffer { | |||
| case html.TextToken: | |||
|
|
|||
| if !skipElementContent { | |||
| switch mostRecentlyStartedToken { | |||
| switch strings.ToLower(mostRecentlyStartedToken) { | |||
buro9
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if anything needs adjusting or if you have any questions about this, I'll try to respond quickly.