Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure request is aborted #335

Merged
merged 1 commit into from
Dec 1, 2021
Merged

fix: ensure request is aborted #335

merged 1 commit into from
Dec 1, 2021

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Nov 28, 2021

Related to:
#321 (comment)

not sure if that could be a conflict with the default priority declaration

engine.setRequestInterceptionPriority(1)

.cc @benallfree @remusao

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.479% when pulling 56feb3d on adblock into ed04bca on master.

@Kikobeats
Copy link
Member Author

looking for feedback @benallfree @remusao 🙏

Copy link

@benallfree benallfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

@Kikobeats Kikobeats merged commit 82ddefe into master Dec 1, 2021
@Kikobeats Kikobeats deleted the adblock branch December 1, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants