Skip to content

Commit

Permalink
Merge pull request #701 from microlinkhq/next
Browse files Browse the repository at this point in the history
fix(publisher): remove too generic rule
  • Loading branch information
Kikobeats committed Apr 25, 2024
2 parents 495278e + 640abe9 commit 376e1dc
Show file tree
Hide file tree
Showing 7 changed files with 4,150 additions and 2 deletions.
1 change: 0 additions & 1 deletion packages/metascraper-publisher/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ module.exports = () => ({
toPublisher($ => $filter($, $('#logo'))),
toPublisher($ => $filter($, $('.logo'))),
toPublisher($ => $filter($, $('a[class*="brand" i]'))),
toPublisher($ => $filter($, $('[class*="brand" i]'))),
toPublisher($ => $('[class*="logo" i] a img[alt]').attr('alt')),
toPublisher($ => $('[class*="logo" i] img[alt]').attr('alt')),
toPublisher($ => $filter($, $('title'), el => getFromTitle($filter.fn(el))))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Generated by [AVA](https://avajs.dev).
description: 'Segment is the analytics API you’ve always wanted. It’s the easiest way to install all of your favorite analytics tools at once!',
image: 'https://c19f7be2e84987e7904e-bf41efcb49679c193a4ec0f3210da86f.ssl.cf1.rackcdn.com/photos/40528-1-1.jpg',
lang: null,
logo: 'https://t0.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=https://segment.com/blog/scaling-nsq&size=128',
logo: 'https://t2.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=https://segment.com/blog/scaling-nsq&size=128',
publisher: 'Segment Blog',
title: 'Scaling NSQ to 750 Billion Messages',
url: 'https://segment.com/blog/scaling-nsq',
Expand Down
Binary file not shown.
31 changes: 31 additions & 0 deletions packages/metascraper/test/integration/therams/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
'use strict'

const { readFile } = require('fs/promises')
const { resolve } = require('path')
const test = require('ava')

const metascraper = require('../../..')([
require('metascraper-author')(),
require('metascraper-date')(),
require('metascraper-description')(),
require('metascraper-audio')(),
require('metascraper-video')(),
require('metascraper-image')(),
require('metascraper-lang')(),
require('metascraper-logo')(),
require('metascraper-logo-favicon')(),
require('metascraper-publisher')(),
require('metascraper-title')(),
require('metascraper-url')(),
require('metascraper-readability')()
])

const url =
'https://www.therams.com/news/cooper-kupp-being-present-best-version-of-himself-prepares-2024-season'

test('therams', async t => {
const html = await readFile(resolve(__dirname, 'input.html'))
const metadata = await metascraper({ html, url })
console.log(metadata)
t.snapshot(metadata)
})

0 comments on commit 376e1dc

Please sign in to comment.