New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary test workflow, checks that key downstream packages still build #106
Canary test workflow, checks that key downstream packages still build #106
Conversation
This comment has been minimized.
This comment has been minimized.
1d3fe8c
to
28e83d5
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the CI failure is most important, otherwise, good idea!
Perhaps something to not run this on every PR? Similar to that “T-Shaped” model from MDX? |
I think there would be value in running this on every PR, seeing if code changes impact upstream.
There the T-Shaped model has to do with the matrix of jobs run, not when it is run, right? |
I'm not sure if it can.
Happy to rename things if wanted, I'm not sure it will fix the order issue though. |
Yeah, though, taking MDX as an example: mdx-js/mdx#1854, it seems to indicate that different YAML files result in unordered, but when inside the same file, it does work?
I meant the points separately. I guess |
90b297f
to
42e5976
Compare
Moved canary job into main.yml
it is more about the repositories, updated naming to better reflect this |
Initial checklist
Description of changes
Follow up to: unifiedjs/ideas#7
This aims to help alleviate some of that risk by choosing a few key packages.
which build on this, and have heavy usage, and comprehensive test suites, to anticipate potential downstream issues faster.