Avoid needing compiler parameter metadata in CountedAspect #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
enhancement
sbrannen
reviewed
Apr 20, 2023
| @Around("@annotation(counted)") | ||
| public Object interceptAndRecord(ProceedingJoinPoint pjp, Counted counted) throws Throwable { | ||
| @Around("@annotation(io.micrometer.core.annotation.Counted)") | ||
| public Object interceptAndRecord(ProceedingJoinPoint pjp) throws Throwable { |
There was a problem hiding this comment.
If you want to keep the signature as it was without requiring -parameters, does the following meet your needs?
@Around(value = "@annotation(counted)", argNames = "counted")
public Object interceptAndRecord(ProceedingJoinPoint pjp, Counted counted) throws Throwable {There was a problem hiding this comment.
That sounds like it should work. Thank you for the suggestion. Let's try that.
Info about the parameter name is not necessarily available unless we compile with `-parameters`. Explicitly give `argNames` to avoid needing to compile with `-parameters`.
shakuzen
force-pushed
the
counted-named-param
branch
from
ac6176d
to
da872a5
Compare
shakuzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info about the parameter name is not necessarily available unless we compile with
-parameters. Explicitly giveargNamesto avoid needing to compile with-parameters.This is technically breaking public API, but an Aspect class should generally only have its constructor(s) called by users, so I felt this shouldn't be a problem even in a patch release. Let me know if anyone disagrees.Thanks to @sbrannen's suggestion, we can make an alternate change that maintains the API signature.
See #3776