MeterTags wrapper to support multiple MeterTag-s on a single method parameter #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smaxx Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@smaxx Thank you for signing the Contributor License Agreement! |
smaxx
changed the title
marcingrzejszczak
approved these changes
May 7, 2024
jonatan-ivanov
requested changes
May 7, 2024
micrometer-core/src/main/java/io/micrometer/core/aop/MeterTags.java
Outdated
Show resolved
Hide resolved
micrometer-commons/src/main/java/io/micrometer/common/annotation/AnnotationUtils.java
Show resolved
Hide resolved
micrometer-core/src/main/java/io/micrometer/core/aop/MeterTags.java
Outdated
Show resolved
Hide resolved
micrometer-core/src/test/java/io/micrometer/core/aop/TimedAspectTest.java
Outdated
Show resolved
Hide resolved
…ethod parameter. Review fixes
jonatan-ivanov
approved these changes
May 8, 2024
|
We can merge this next week after we released 1.13.0. |
shakuzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ethod parameter
Resolves #4081