Make it possible to read logback version from catalog #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to read the default logback version from the `mnLogging` catalog instead of the `libs` catalog or Gradle properties. It also removes the default version as it is likely to be outdated in any case and raise problems. The same should probably done for objenesis and bytebuddy but it's unclear which projects use it in practice. Fixes #561
msupic
reviewed
May 17, 2023
src/main/groovy/io/micronaut/build/MicronautBuildCommonPlugin.groovy
Outdated
Show resolved
Hide resolved
In addition, dependencies will only be added if the version is found in a catalog (this is also true for logback version). For bytebuddy and objenesis, the version will be fetched from `libs`, but also from `mnTest`. Currently, the Micronaut Test catalog doesn't declare these, but it feels like "the right place".
sdelamo
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to read the default logback version from the
mnLoggingcatalog instead of thelibscatalog or Gradle properties. It also removes the default version as it is likely to be outdated in any case and raise problems.The same should probably done for objenesis and bytebuddy but it's unclear which projects use it in practice.
Fixes #561