Inline dependencies from Micronaut BOMs into the generated BOM #690
+65
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds inlining of dependencies from imported Micronaut BOMs into the generated BOM. The dependencies are added _before_ the imported BOMs so that we make sure that they take precedence in Maven. In addition, we still have a <scope>import</scope> dependency on the Micronaut BOMs because they themselves may import other BOMs which are not Micronaut BOMs. If we removed the import then we would loose some dependency constraints. Fixes #689
alvarosanchez
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds inlining of dependencies from imported Micronaut BOMs into the generated BOM. The dependencies are added before the imported BOMs so that we make sure that they take precedence in Maven.
In addition, we still have a import dependency on the Micronaut BOMs because they themselves may import other BOMs which are not Micronaut BOMs. If we removed the import then we would loose some dependency constraints.
This fixes the problem that despite the fact our BOM declares dependency versions, these are ignored when the user overrides them.
It's worth noting that this isn't a recursive behavior, so if an imported catalog wasn't itself published with this code, its downstream catalogs won't be inlined.
Fixes #689