Merge branch '4.1.x' into '4.2.x' #10099
Merged
+2,326
−1,412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add eq/hc for HttpVersionSelection Fixes #9994
This was an oversight, but I think 0 should be handled the same way so not sure this PR changes anything in practice.
It is legal for a reactive publisher to call onComplete immediately after subscribe, before data is requested. This could lead to a failure when such a publisher was queued for write. Addresses #9677
* tck: form-url-encoded with field with list see: micronaut-projects/micronaut-serialization#616 * remove unused imports
* Do not try to apply JsonView to failed responses As the failed response contains a body not returned by the controller method, don't try to apply the controller's JsonView to it. Fixes #9975 * fix test * Apply suggestions from code review Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com> * Update http-server-netty/src/main/java/io/micronaut/http/server/netty/jackson/JsonViewServerFilter.java --------- Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
The blocking filter would cause onSubscribe to be delayed, leading to a logged exception when trying to request from upstream. This patch simply skips the request call in that case. The request will be done in onSubscribe later. Also make sure the subscriber methods are only called on the event loop to avoid concurrency issues.
Connection.hasLiveRequests was set to true by the earmark operation at the start of Connection.dispatch, but the read timeout is only reset on the event loop just before dispatch0. That means that a read timeout could trigger after hasLiveRequests becomes true but before the reset, leading to an unhandled timeout and wasted connection. The fix is to separate the "earmark" flag from the hasLiveRequests flag (or counter for HTTP/2). They will usually have the same value, except in the short interval before dispatch0, where earmark is true but hasLiveRequests is not. This means the read timeout is ignored before the timeout is reset. Fixes #9899
If the response is written before the request body is consumed, RIB would subscribe to the body to release the incoming data. This was not necessary, as PipeliningServerHandler already has more efficient discard logic triggered by closeIfNoSubscriber. This made no functional difference, but it's faster with this PR.
* Cleanup Gradle JVM compatibility checks * Unwrap enable preview
#10084) * Reduce PoolTimeout flakiness Try to reduce the flakiness by using Requires and AutoCleanup to try and reduce pollution that may be occuring * Remove Shared from ClientIntroductionAdviceSpec as it needs a fresh server each test
Seems the test was just broken. The internal error goaway frame made netty close the channel, which may send some bogus TLS and doesn't actually hit the code this test was supposed to test. Please try on mac.
…le:/{JAR_PATH}!/{PREFIX}!/{RESOURCE}` gracefully (#10092)
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.