Optimize routing #10177
Merged
Optimize routing #10177
+217
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
approved these changes
Dec 4, 2023
| } | ||
| }; | ||
| return filterRunner.run(request); | ||
| } catch (Throwable e) { |
There was a problem hiding this comment.
it's really ugly that that can fail all over the place now
There was a problem hiding this comment.
It will now fail during the filter check and propagate the errors. After the URI change, it will fail before the route execution and propagate the error in filters.
There was a problem hiding this comment.
well if the filters dont need the route it can now fail in a controller too. it can fail anywhere
There was a problem hiding this comment.
Only if you disable the validation the other PR
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10172