Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FastThreadLocal for context propagation if available #10254

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Dec 13, 2023

From #10131

@yawkat yawkat added the type: improvement A minor improvement to an existing feature label Dec 13, 2023
@yawkat yawkat added this to the 4.3.0 milestone Dec 13, 2023
@dstepanov
Copy link
Contributor

Can we have an abstraction around the thread context and only switch to Netty's implementation when it's available (server/client)?

@yawkat
Copy link
Member Author

yawkat commented Dec 13, 2023

I don't understand what you mean? If netty is not on the classpath, the SLOW variable will be used. If netty is on the classpath but the current thread is not a netty FastThreadLocalThread, then netty FastThreadLocal has its own handling already that falls back on ThreadLocal.

@dstepanov
Copy link
Contributor

Ah right, I didn't notice compileOnly

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
95.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants