Skip to content

accept breaking changes #10405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024
Merged

accept breaking changes #10405

merged 1 commit into from
Jan 23, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jan 23, 2024

Most breaking changes accepted by this PR were introduced in:

- [AST: Introduce MethodElement#getOverriddenMethods to get all the methods overridden by this method](#10342)
- [Avoid having TypeConverter defined as beans](https://github.com/micronaut-projects/micronaut-core/pull/10315/files)
@sdelamo sdelamo added this to the 4.3.0 milestone Jan 23, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dstepanov
Copy link
Contributor

Why do we need to track the backward compatibility of the TCK? I think we should try to generate the metadata with the internal annotation to avoid the check.

@sdelamo
Copy link
Contributor Author

sdelamo commented Jan 23, 2024

Why do we need to track the backward compatibility of the TCK? I think we should try to generate the metadata with the internal annotation to avoid the check.

Please, note there are many breaking changes accepted in this PR. The TCK accepted changes are a minority.

@sdelamo sdelamo merged commit 011ebe5 into 4.3.x Jan 23, 2024
@sdelamo sdelamo deleted the fix-jpicmp branch January 23, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants