Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change Grails creator copy #10431

Merged
merged 3 commits into from
Feb 13, 2024
Merged

doc: change Grails creator copy #10431

merged 3 commits into from
Feb 13, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jan 30, 2024

similar changes to the modification introduced in the REAdME file here: #10087

Incorporate same changes introduced in the REAdME file here: #10087
@sdelamo sdelamo requested a review from wiesej January 30, 2024 14:52
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor Author

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiesej asked me to change the copy. @graemerocher can you review it.

@sdelamo sdelamo requested a review from graemerocher January 31, 2024 05:31
@graemerocher
Copy link
Contributor

can the motivation be explained for the change?

@sdelamo
Copy link
Contributor Author

sdelamo commented Feb 13, 2024

can the motivation be explained for the change?

I think the motivation was to stop saying the framework is actively developed by Grails crew and change it to past tense. I changed only in README.md, but the exact copy appears in the docs, and I missed that in the other PR.

@wiesej told me to change the copy to passive voice and be as in this PR. She can elaborate more on the motivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants