processor finalization stacktrace #10467
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TypeElementVisitorProcessor calls the `.finish()` method on visitors and catches all exceptions if present. But the message might not be descriptive enough. For example a StackOverflowError does not have a message, so the logs would be: `[ERROR] error: Error finalizing type visitor [...Visitor@5e67a490]: null` Since the visitors are not expected to fail frequently, printing stack trace should not have a negative impact on performance.
|
graemerocher
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeElementVisitorProcessor calls the
.finish()method on visitors and catches all exceptions if present. But the message might not be descriptive enough. For example a StackOverflowError does not have a message, so the logs would be:Since the visitors are not expected to fail frequently, printing stack trace should not hurt performance.