Move empty arrays to static variables #10539
Merged
+161
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
approved these changes
Feb 24, 2024
graemerocher
added
the
type: improvement
grayc-de-bot
pushed a commit
to inoa-io/inoa-cloud
that referenced
this pull request
Mar 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.micronaut:micronaut-inject-java](https://micronaut.io) ([source](https://github.com/micronaut-projects/micronaut-core)) | | patch | `4.3.9` -> `4.3.10` | | [io.micronaut:micronaut-inject-java](https://micronaut.io) ([source](https://github.com/micronaut-projects/micronaut-core)) | compile | patch | `4.3.9` -> `4.3.10` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>micronaut-projects/micronaut-core (io.micronaut:micronaut-inject-java)</summary> ### [`v4.3.10`](https://github.com/micronaut-projects/micronaut-core/releases/tag/v4.3.10): Micronaut Core 4.3.10 [Compare Source](micronaut-projects/micronaut-core@v4.3.9...v4.3.10) <!-- Release notes generated using configuration in .github/release.yml at 4.3.x --> ##### What's Changed ##### Bug Fixes 🐞 - KSP: Allow to detect repeatable annotations using reflection by [@​dstepanov](https://github.com/dstepanov) in micronaut-projects/micronaut-core#10576 ##### Improvements ⭐ - Move empty arrays to static variables by [@​altro3](https://github.com/altro3) in micronaut-projects/micronaut-core#10539 ##### Other Changes 💡 - tck: don’t depend on jackson databind by [@​sdelamo](https://github.com/sdelamo) in micronaut-projects/micronaut-core#10546 ##### Dependency updates 🚀 - fix(deps): update groovy monorepo to v4.0.19 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10567 - fix(deps): update dependency com.github.javaparser:javaparser-symbol-solver-core to v3.25.9 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10571 - fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.3 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10583 - fix(deps): update managed.ksp to v1.9.22-1.0.18 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10577 - fix(deps): update dependency org.testcontainers:spock to v1.19.7 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10540 - fix(deps): update dependency com.squareup.okio:okio to v3.8.0 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10481 ##### Micronaut Modules ##### Micronaut Validation - fix(deps): update dependency io.micronaut.validation:micronaut-validation-bom to v4.4.3 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10560 ##### Micronaut AWS - fix(deps): update dependency io.micronaut.aws:micronaut-aws-bom to v4.4.2 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10548 ##### CI ⚙️Build 🐘 ##### GraalVM - Update graalvm/setup-graalvm action to v1.1.8 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10530 ##### Micronaut Build Plugin - chore(deps): update plugin io.micronaut.build.shared.settings to v6.6.4 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10566 - chore(deps): update dependency io.micronaut.build.internal:micronaut-gradle-plugins to v6.6.4 by [@​renovate](https://github.com/renovate) in micronaut-projects/micronaut-core#10565 **Full Changelog**: micronaut-projects/micronaut-core@v4.3.9...v4.3.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzEuMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.grayc.io/inoa/cloud/pulls/78 Reviewed-by: Stephan Schnabel <stephan.schnabel@grayc.de> Co-authored-by: Renovate <renovate@grayc.io> Co-committed-by: Renovate <renovate@grayc.io>
timyates
added a commit
that referenced
this pull request
Mar 11, 2024
When we have a Graal/Kotlin/Maven project we add micronaut-graal to the Kapt annotation processor paths. When we moved empty arrays to static variables in #10539, we added a requirement for micronaut-core to be also on the classpath. This PR breaks that requirement, so just adding micronaut-graal to the processors is enough.
sdelamo
pushed a commit
that referenced
this pull request
Mar 11, 2024
When we have a Graal/Kotlin/Maven project we add micronaut-graal to the Kapt annotation processor paths. When we moved empty arrays to static variables in #10539, we added a requirement for micronaut-core to be also on the classpath. This PR breaks that requirement, so just adding micronaut-graal to the processors is enough.
timyates
added a commit
that referenced
this pull request
Mar 12, 2024
This reverts commit 36ef6b9. This PR #10597 was an attempt to fix Maven, Graal and Kapt, but it was in error... The issue wasn't that micronaut-graal was calling micronaut-core. The issue was that the Kotlin processor had both Micronaut-core 4.3.1 and 4.3.10 in the classpath. Due to the unique way Maven deals with resolution issues (it just picks the first one it sees), this meant that the processor couldn't see the variables added and renamed in #10539. And for Kapt, there's nothing we can do to manage this (apart from add every module in micronaut-core to the annotationProcessorPaths). We are testing fixing it by re-releasing processors with the 4.3.10 version of core.
sdelamo
pushed a commit
that referenced
this pull request
Mar 12, 2024
This reverts commit 36ef6b9. This PR #10597 was an attempt to fix Maven, Graal and Kapt, but it was in error... The issue wasn't that micronaut-graal was calling micronaut-core. The issue was that the Kotlin processor had both Micronaut-core 4.3.1 and 4.3.10 in the classpath. Due to the unique way Maven deals with resolution issues (it just picks the first one it sees), this meant that the processor couldn't see the variables added and renamed in #10539. And for Kapt, there's nothing we can do to manage this (apart from add every module in micronaut-core to the annotationProcessorPaths). We are testing fixing it by re-releasing processors with the 4.3.10 version of core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.