Code cleanup for inject-java #10949
Code cleanup for inject-java #10949
Conversation
altro3
force-pushed
the
cleanup-inject-java
branch
4 times, most recently
from
bf564ee to
8262f03
Compare
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public ClassElement withTypeArguments(@NonNull Collection<ClassElement> typeArguments) { | ||
| if (getTypeArguments().equals(typeArguments)) { |
There was a problem hiding this comment.
This code is incorrect. You try to compare map with collection
| @@ -618,8 +622,8 @@ public Optional<ClassElement> getEnclosingType() { | |||
| Element enclosingElement = this.classElement.getEnclosingElement(); | |||
| if (enclosingElement instanceof TypeElement typeElement) { | |||
| return Optional.of(visitorContext.getElementFactory().newClassElement( | |||
| typeElement, | |||
| elementAnnotationMetadataFactory | |||
There was a problem hiding this comment.
you have 2 styles in these classes. Which continuation indent right? 8 spaces or 4 spaces?
There was a problem hiding this comment.
@graemerocher could you tell me which codestyle is right?
| @@ -431,7 +435,7 @@ public <T extends io.micronaut.inject.ast.Element> List<T> getEnclosedElements(@ | |||
| * {@link io.micronaut.inject.ast.ElementFactory#newSourceMethodElement(ClassElement, Object, ElementAnnotationMetadataFactory)}. | |||
| * | |||
| * @param query The query | |||
| * @param <T> The element type | |||
There was a problem hiding this comment.
you have 2 styles in these classes. Do we need Align parameter / thrown exception decriptions or not?
There was a problem hiding this comment.
@graemerocher could you tell me which codestyle is right?
| @Override | ||
| public boolean isPrimitive() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Unnecessary describe default implementation
altro3
force-pushed
the
cleanup-inject-java
branch
from
8262f03 to
0f43f74
Compare
altro3
force-pushed
the
cleanup-inject-java
branch
from
0f43f74 to
aba094d
Compare
graemerocher
added
the
type: improvement
|
@graemerocher Repeat questions: you have 2 styles in these classes. Which continuation indent right? 8 spaces or 4 spaces? you have 2 styles in these classes. Do we need Align parameter / thrown exception decriptions or not? |
|
whatever check style says is correct :) |
No description provided.